Skip to content

Release/1.4.0#1166

Merged
ttypic merged 2 commits intomainfrom
release/1.4.0
Sep 27, 2025
Merged

Release/1.4.0#1166
ttypic merged 2 commits intomainfrom
release/1.4.0

Conversation

@ttypic
Copy link
Contributor

@ttypic ttypic commented Sep 26, 2025 •
edited by coderabbitai bot
Loading

Release 1.4.0

Summary by CodeRabbit

  • New Features

    • Added Protocol v4 support.

  • Bug Fixes

    • Corrected handling of clipped client ID lists and aggregation.
    • Improved WebSocket lifecycle stability.

  • Documentation

    • Updated Change Log with 1.4.0 release notes.
    • Refreshed setup instructions to use 1.4.0 dependencies.

  • Tests

    • Updated version assertions to 1.4.0.

  • Chores

    • Bumped project version to 1.4.0.

@coderabbitai
Copy link

coderabbitai bot commented Sep 26, 2025 •
edited
Loading

Walkthrough

Version bumped from 1.3.0 to 1.4.0 across docs, build properties, and tests. CHANGELOG adds 1.4.0 notes. CONTRIBUTING and README dependency references updated to 1.4.0. gradle.properties VERSION_NAME set to 1.4.0. A unit test expected agent header string updated to reflect 1.4.0.

Changes

Cohort / File(s) Summary
Changelog update
CHANGELOG.md		 Added 1.4.0 section with notes on Protocol v4 support, clipped client ID handling, and WebSocket lifecycle improvements.
Dependency/version references
CONTRIBUTING.md, README.md, gradle.properties		 Updated Ably-related dependency versions and VERSION_NAME from 1.3.0 to 1.4.0 in docs and build properties.
Test expectation update
lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java		 Adjusted expected agent header string from ably-java/1.3.0 to ably-java/1.4.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at version’s gleam,
Hop to 1.4 like a caffeined dream.
Changelogs nibble, headers align,
Gradle burrows to a tidy 1.4.0 sign.
With thumps of joy, I stamp the ground—
New carrots found, all safely bound! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title directly indicates the purpose of the changeset—publishing version 1.4.0—and aligns with the updates to the changelog, dependency versions, and tests, making it a clear summary of the main change.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/1.4.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ttypic ttypic requested a review from AndyTWF September 26, 2025 16:22
coderabbitai[bot]
coderabbitai bot reviewed Sep 26, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 438201c and 1bd8f31.

📒 Files selected for processing (5)
  • CHANGELOG.md (1 hunks)
  • CONTRIBUTING.md (1 hunks)
  • README.md (3 hunks)
  • gradle.properties (1 hunks)
  • lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: check-liveobjects
  • GitHub Check: check-rest-okhttp
  • GitHub Check: check-realtime-okhttp
  • GitHub Check: check-realtime
  • GitHub Check: check-rest
  • GitHub Check: check (29)
  • GitHub Check: check (24)
  • GitHub Check: check (21)
  • GitHub Check: check (19)
  • GitHub Check: check
  • GitHub Check: build
  • GitHub Check: check (29)
🔇 Additional comments (4)
CONTRIBUTING.md (1)

238-238: Updated local AAR reference looks good

Thanks for keeping the CONTRIBUTING instructions aligned with 1.4.0.

lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1)

90-92: Agent header assertion stays in lockstep with the release

Nice job updating the test expectation to 1.4.0 so the agent-header contract stays green with the new release.

README.md (1)

54-144: Version references updated accurately

All installation snippets now point to 1.4.0, keeping the docs aligned with the release.

CHANGELOG.md (1)

3-11: Changelog entry looks complete

The 1.4.0 section clearly lists the key PRs and comparison link—no issues spotted.

@ttypic ttypic merged commit 13b8e2e into main Sep 27, 2025
14 checks passed
@ttypic ttypic deleted the release/1.4.0 branch September 27, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@AndyTWF AndyTWF AndyTWF approved these changes

@maratal maratal maratal approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ttypic @AndyTWF @maratal